Gitlab Community Edition Instance

Skip to content
Snippets Groups Projects

Bugfix/#54 edition plain text arabic

Merged Michelle Weidling requested to merge bugfix/#54-Edition_plain_text_Arabic into develop

Bug fix

Related Tickets

#54 (closed)

Does the result of the MR comply to our "definition of done"?

  • Unit tests passed
  • Code reviewed
  • Acceptance criteria met
  • Functional tests passed
  • Non-Functional requirements met
  • Product Owner accepts the User Story

Closes

#54 (closed)

Summary

  • Certain manifests have been excluded from being listed in collection.json since they aren't editions in a stricter sense–they lack an XML and have been created by the scholars for their workflow.

  • tapi:make-editors() has been made more robust by always returning content; In case no editor is found, it returns none.

  • Furthermore, the unit tests have been slightly improved wrt. performance and quality:

    • some errors have been corrected
    • the tests for the AnnotationAPI are now pending since they don't work properly
    • tapi:zip-text() only runs once since it is time consuming

Changelog

  • I added a statement to the CHANGELOG.

Version number

  • I bumped the version number in build.properties.

/cc Mathias Göbel, Frank Schneider, Michelle Weidling

Merge request reports

Pipeline #149004 passed

Pipeline passed for b79b8804 on bugfix/#54-Edition_plain_text_Arabic

Merged by Michelle WeidlingMichelle Weidling 4 years ago (Sep 2, 2020 5:22am UTC)

Loading

Pipeline #149186 passed

Pipeline passed for 252c091f on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading