Feature/#52 annotationapi tests
Feature
Summary
This MR provides…
- extensive tests for the AnnotationAPI. For this, some minor changes several functions have been made and several minor bugs fixed.
- the annotation module has been split to
annotation.xqm
andannotation-rest.xqm
, the latter holding only the REST interface definitions. Both reside now in their own collection,modules/AnnotationAPI
, which makes the app a bit more clear. - a better structure of the modules by moving the fragment retrieval to
commons.xqm
. This way,annotations.xqm
doesn't have to importtapi-html.xqm
which makes no sense (the HTML creation is logically independent from the annotations). -
test-runner.xq
which can be used for local unit testing now inherits fromtest-trigger.xqm
, thus reducing duplications (DRY!). Cf. #62 (closed) - The output of the tests have been remodeled to be both human and machine readable which addresses #61 (closed).
- The sample files have been renamed for clarity and slightly altered/enhanced to better depict the project's data structure.
- The content of
repo.xml
has been shortened in order to avoid having version information on two places.
Compliance to “Definition of Done”
-
Unit tests passed -
Code reviewed -
Acceptance criteria met -
Functional tests passed -
Non-Functional requirements met -
Product Owner accepts the User Story
Documentation
-
I updated existing documentation
Tests
Are we able to test this new feature?
-
Yes, everything can be done via unit tests.
Changelog
-
I added a statement to the CHANGELOG.
Version number
-
I bumped the version number in build.properties
.
Related Tickets
Closes
Closes #52 (closed), #61 (closed), #62 (closed).
Edited by Michelle Weidling
Merge request reports
Activity
changed milestone to %Ahikar Version 0.13.0
added Ahikar label
assigned to @mgoebel
added 3 commits
-
6085c4bf...4e393fb7 - 2 commits from branch
develop
- ce3ff89a - Merge branch 'develop' into feature/#52 (closed)-annotationapi-tests
-
6085c4bf...4e393fb7 - 2 commits from branch
added 1 commit
- 9c9a1b34 - tests: adjust path to new name of Kant sample file
added 6 commits
- 387df95a - fix: adjust faux sample to current format
- dd449c63 - fix: add missing reference to TILE
- 332b375b - refactor: remove dead code, consider only availble TILEs
- bb04baf6 - tests: fix file names; add setup and teadown for clarity
- 22741ae5 - tests: re-add test data (still needed)
- 712762c3 - tests: adjust to changes in sample_edition
Toggle commit listadded 1 commit
- f2efa9c3 - tests: add tearDown, fix errors caused by MR, remove surplus test
- A deleted user
merged
Please register or sign in to reply