Gitlab Community Edition Instance

Skip to content

Resolve "Subscription Depletion"

Jan Maximilian Michal requested to merge 92-subscription-depletion into master

Subscription enhancements

  • It is now possible to 'deactivate subscriptions via the delete http verb
  • This is not exactly what was specified in #92 (closed) but should achieve the same result. Instead of introducing a depleted field, subscriptions can distinguish if they are fully depleted or just temporarily. The method does not involve any overhead.
  • Refactorings in the subscription model to increase readability
  • Creating a subscription does not have side effects (creates no assignment)

Other minor changes

  • Assignments are now implicitly checked if feedback is created
  • using the assignment endpoint to create subscriptions instead of subscription endpoint

Migrated everything to UUID fields for primary keys

  • submission_pk -> submission on AssignmentSerializer
  • subscriptions now uniformly use the primary key of a model for the query_key
  • introduced remaining and available fields on subscription
  • query key and type are now validated

Closes #93 (closed) and #92 (closed).

Edited by Jan Maximilian Michal

Merge request reports