pycdstar3 merge requestshttps://gitlab-ce.gwdg.de/cdstar/pycdstar3/-/merge_requests2019-10-25T14:15:03Zhttps://gitlab-ce.gwdg.de/cdstar/pycdstar3/-/merge_requests/5Added keepalive functionality2019-10-25T14:15:03ZMarcel HellkampAdded keepalive functionalityDoes this make sense? Or is this a feature no one actually needs and that adds unneeded complexity?Does this make sense? Or is this a feature no one actually needs and that adds unneeded complexity?https://gitlab-ce.gwdg.de/cdstar/pycdstar3/-/merge_requests/4Alternative command registration mechanism2019-10-09T11:44:33ZrforkelAlternative command registration mechanismIn this setup commands are registered by simply subclassing
`pycdstar3.cli.commands.base.Command`, i.e. a new command can be added
by only dropping a module with the implementation into `pycdstar3/cli/commands`,
thus obeying the principl...In this setup commands are registered by simply subclassing
`pycdstar3.cli.commands.base.Command`, i.e. a new command can be added
by only dropping a module with the implementation into `pycdstar3/cli/commands`,
thus obeying the principle of locality.
Another advantage of this approach is that the `Command` base class can
implement generic functionality, like calling `subparsers.add_parser` and
setting the `main` property.
A slight disadvantage is the somewhat hacky way to import all modules in
`pycdstar3/cli/commands`.
Right now, commands are registered under their class name, but some decorator
magic could help in case a command name might clash with - say - a python
keyword.https://gitlab-ce.gwdg.de/cdstar/pycdstar3/-/merge_requests/3More tests2019-10-08T10:28:40ZrforkelMore testsThis PR mostly fleshes out tests, with the one exception of an added `CDStar.GET` method.
I'm not sure, how the API is intended to "feel", but I was looking for a way to get all info about an archive for which I already have the ID - so ...This PR mostly fleshes out tests, with the one exception of an added `CDStar.GET` method.
I'm not sure, how the API is intended to "feel", but I was looking for a way to get all info about an archive for which I already have the ID - so looking up the docs at https://cdstar.gwdg.de/docs/dev/#getArchiveInfo I knew how to do this using `CDStar._rest`, but didn't want to call an internal method.