GitLab

Also reworked the way AsyncContext timeouts are tracked.

Fix: Do not require list_files permission just to show the file count.
Change: Return a partial ArchiveInfo even if sub-resources requested with
'with' are not available due to access restrictions.

This change should help clients trying to get as much information as
possible with a single request and reduce complexity and latency when
viewing cdstar archives.

The GC now simply scans the directory and identifies index and binary
files to keep, based on last modification time alone. It no longer walks
the revision history, so missing revisions won't be a problem.
The "Keep N revisions" feature was removed, as it makes no sense. A user
might create 100 revisions a second, or none in a year. Revisions should
only be considered to allow MVCC, not be a 'history' of changes that one
might want to preserve. If so, GC must be disabled completely.

A single user can grow the cache very fast (e.g. by rapitdy modifying a
large archive without using transactions). We could purge old revisions on
commit to counter exactly this scenario, or just use soft references again
to prevent OOM situations. Time based eviction is not sufficient. We do
that anyway to free memory even if memory pressure is not high enough to
cause soft reference collection.

Admin users with special permissions should be able to submit privileged
unfiltered searches in the future.

Triggering full GCs should not be required. Only for testing.

The workaround is not ideal, but works for now.

So any but the first of many parallel rollback() or commit() calls
will fail fast and less threads are blocked.

Client usually does not care about a transaction after rollback